-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update icewind/smb to 3.5.4 #32632
update icewind/smb to 3.5.4 #32632
Conversation
icewind1991
commented
May 27, 2022
•
edited
Loading
edited
- Fixes SMB External storage webdav path adds extra string "Dc" and causes share to be not accessible #29003
- Fixes timezone handling in some cases
/backport to stable24 |
/backport to stable23 |
|
||
if ($result === 0 && isset($output[0])) { | ||
$this->paths[$binary] = (string)$output[0]; | ||
} else if (is_executable("/usr/bin/$binary")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} else if (is_executable("/usr/bin/$binary")) { | |
} elseif (is_executable("/usr/bin/$binary")) { |
Not blocking but should still be fixed upstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@come-nc can you submit a PR upstream ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/rebase |
rebased for CI, the SMB tests should at least pass |
52fe991
to
a409372
Compare
I believe the sso tests are failing due to an issue with the user_saml setup, I'll need to take some time to debug that |
/rebase |
a409372
to
12b4769
Compare
/rebase |
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
12b4769
to
30b7147
Compare
CI failure unrelated |
/backport to stable26 |
/backport to stable25 |
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin/stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin/stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |