Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icewind/smb to 3.5.4 #32632

Merged
merged 2 commits into from
Apr 18, 2023
Merged

update icewind/smb to 3.5.4 #32632

merged 2 commits into from
Apr 18, 2023

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented May 27, 2022

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label May 27, 2022
@icewind1991 icewind1991 added this to the Nextcloud 25 milestone May 27, 2022
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, blizzz and juliusknorr and removed request for a team May 27, 2022 15:40
@icewind1991
Copy link
Member Author

/backport to stable24

@icewind1991
Copy link
Member Author

/backport to stable23

@icewind1991 icewind1991 changed the title update icewind/smb to 3.5.3 update icewind/smb to 3.5.4 May 30, 2022

if ($result === 0 && isset($output[0])) {
$this->paths[$binary] = (string)$output[0];
} else if (is_executable("/usr/bin/$binary")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} else if (is_executable("/usr/bin/$binary")) {
} elseif (is_executable("/usr/bin/$binary")) {

Not blocking but should still be fixed upstream

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@come-nc can you submit a PR upstream ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PVince81
Copy link
Member

/rebase

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 15, 2022
@PVince81
Copy link
Member

rebased for CI, the SMB tests should at least pass

@icewind1991
Copy link
Member Author

icewind1991 commented Aug 15, 2022

I believe the sso tests are failing due to an issue with the user_saml setup, I'll need to take some time to debug that

@skjnldsv skjnldsv mentioned this pull request Aug 18, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@PVince81
Copy link
Member

/rebase

@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@juliusknorr juliusknorr removed their request for review March 24, 2023 11:10
@szaimen
Copy link
Contributor

szaimen commented Apr 17, 2023

/rebase

@szaimen szaimen enabled auto-merge April 17, 2023 14:51
@szaimen
Copy link
Contributor

szaimen commented Apr 18, 2023

CI failure unrelated

@szaimen
Copy link
Contributor

szaimen commented Apr 18, 2023

/backport to stable26

@szaimen
Copy link
Contributor

szaimen commented Apr 18, 2023

/backport to stable25

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SMB External storage webdav path adds extra string "Dc" and causes share to be not accessible
6 participants