Fix unresponsive navigation menu on mobile

[Pytal]

Fix #28613

Snapper open and close function calls were deferred to catch events correctly after dragging to set the animating boolean value correctly so that the snapper would be opened and closed correctly on the next interaction

server/core/src/init.js

Lines 265 to 277 in cf97a8e

	const _snapperOpen = () => {
	if (animating || snapper.state().state !== 'closed') {
	return
	}
	oldSnapperOpen('left')
	}
	const _snapperClose = () => {
	if (animating || snapper.state().state === 'closed') {
	return
	}
	oldSnapperClose()
	}

These functions were deferred as a part of #23785

There does not seem to be an issue with catching the events and setting the animating boolean value correctly so that the snapper opens and closes as expected

Remarks

The animating event will fire every millisecond ad infinitum when tapping to close the menu. The UI still works as expected. This would be fixed by setting the tapToClose option https://github.com/JoeyAndres/Snap.js#settings-and-defaults on snap.js to false but this would introduce another issue which causes swipe to close to fail on mobile, so this issue remains

The issue may be fully addressed as a part of #28063

[PVince81]

will fire every millisecond ad infinitum

my previous work was intended to prevent this
I remember that this caused performance issues during calls because of too many events, so I think we should avoid bringing this back if possible

[Pytal]

my previous work was intended to prevent this I remember that this caused performance issues during calls because of too many events, so I think we should avoid bringing this back if possible

The situation is that the defer from the previous PR did not resolve this specific issue either and may be reproduced on master when tapping/clicking and not when hitting enter to close the navigation menu with a console.log('animating') in this block

server/core/src/init.js

Lines 240 to 244 in eb720b9

	snapper.on('animating', () => {
	// we need this because the trigger button
	// is also implicitly wired to close by snapper
	animating = true
	})

From my analysis with the performance profiler in Chrome DevTools there does not seem to be any unexpected performance impact. Only the listeners continue to increase but this is only because garbage collection is disabled for listeners while recording the performance timeline, as per https://stackoverflow.com/a/46745023, this behaviour may be tested by clicking the trash icon to manually trigger garbage collection during recording. Therefore there does not seem to be any runtime performance impact without the defer, any further insights are welcome @PVince81

[Pytal]

The https://github.com/nextcloud/nextcloud-vue library provides a navigation menu and supports swiping with the AppContent and AppNavigation components, see

• https://github.com/nextcloud/photos/blob/74a5e3dd3e597360fde84884a559bee7cfb427df/src/Photos.vue#L25-L62
• https://github.com/nextcloud/nextcloud-vue/blob/f8b6231235850feba975838900941e52502fa6fa/src/components/AppContent/AppContent.vue#L251-L281
• https://github.com/nextcloud/nextcloud-vue/blob/f8b6231235850feba975838900941e52502fa6fa/src/components/AppNavigation/AppNavigation.vue#L101-L135

As discussed with @PVince81, without continuing to use hacky fixes on top of the legacy https://github.com/jakiestfu/Snap.js library, we will move forward with using the https://github.com/nextcloud/nextcloud-vue library as part of #30135 to resolve this