Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure activities are not created when a deleted calendar object expires #32471

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Make sure activities are not created when a deleted calendar object expires #32471

merged 1 commit into from
Jun 1, 2022

Conversation

tcitworld
Copy link
Member

The deleted_at property was not being fetched in getCalendarObject and then passed into the CalendarObjectDeletedEvent, so the handling in ActivityUpdaterListener didn't work properly.

Added a small assertion in CalDavBackendTest to make sure the key is present. And you get a test for free in ActivityUpdaterListener.

Closes nextcloud/activity#784

@tcitworld tcitworld added this to the Nextcloud 25 milestone May 18, 2022
@tcitworld tcitworld requested a review from a team May 18, 2022 09:18
@ChristophWurst
Copy link
Member

S3 failure is most definitely unrelated.

@ChristophWurst
Copy link
Member

/backport to stable24

@ChristophWurst
Copy link
Member

/backport to stable23

@ChristophWurst
Copy link
Member

/backport to stable22

@kesselb
Copy link
Contributor

kesselb commented Jun 1, 2022

And you get a test for free in ActivityUpdaterListener.

😎

@ChristophWurst ChristophWurst merged commit 4e5ed32 into master Jun 1, 2022
@ChristophWurst ChristophWurst deleted the fix-wrong-dav-activities branch June 1, 2022 15:02
This was referenced Jun 1, 2022
Merged
Merged
Merged
@tcitworld tcitworld mentioned this pull request Jun 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala

@st3iny st3iny Awaiting requested review from st3iny st3iny is a code owner

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: activity and notification feature: caldav Related to CalDAV internals
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

Deletion of calendar event reported as being made by another user
3 participants
@tcitworld @ChristophWurst @kesselb