-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event to load additional scripts for projects #32349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
added
3. to review
Waiting for reviews
technical debt
pending documentation
This pull request needs an associated documentation update
labels
May 12, 2022
5 tasks
CarlSchwan
reviewed
May 12, 2022
CarlSchwan
approved these changes
May 12, 2022
Documentation drafted in nextcloud/documentation#8302 |
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
enh/projects-event
branch
from
May 12, 2022 08:50
47f0308
to
ae0e9ff
Compare
1 task
2 tasks
kesselb
approved these changes
May 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Like the fallback approach 😎
juliusknorr
removed
the
pending documentation
This pull request needs an associated documentation update
label
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a public event for apps to listen or register for additional scripts when using the projects feature (OCP\Collaboration\Resources). Previously this was only possible using a static string through the SymfonyAdapter.
A fallback for the old event has been added, so we should mark the old event as deprecated in the developer notes and drop it then 3 versions later.