Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event to load additional scripts for projects #32349

Merged
merged 2 commits into from
May 27, 2022
Merged

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented May 12, 2022

This adds a public event for apps to listen or register for additional scripts when using the projects feature (OCP\Collaboration\Resources). Previously this was only possible using a static string through the SymfonyAdapter.

A fallback for the old event has been added, so we should mark the old event as deprecated in the developer notes and drop it then 3 versions later.

@juliusknorr juliusknorr added 3. to review Waiting for reviews technical debt pending documentation This pull request needs an associated documentation update labels May 12, 2022
@juliusknorr
Copy link
Member Author

Documentation drafted in nextcloud/documentation#8302

Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Like the fallback approach 😎

@CarlSchwan CarlSchwan merged commit e4378fd into master May 27, 2022
@CarlSchwan CarlSchwan deleted the enh/projects-event branch May 27, 2022 16:36
@juliusknorr juliusknorr removed the pending documentation This pull request needs an associated documentation update label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants