Require Primary Keys in all SQL tables #32168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force the existence of PK on all MySQL/MariaDB tables
szaimen
requested review from
nickvergessen,
a team,
ArtificialOwl,
skjnldsv and
vanpertsch
and removed request for
a team
|
Tried that: #31513 Can't find the todo with the remaining tables and apps at the moment. But the change in here is not needed then and would also not artificially break the tests where we test DB migrations. |
|
Oh I see, sad to read that. PK is indeed a must have when scaling is a goal (with Nextcloud, it often is). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force the existence of PK on all MySQL/MariaDB tables.
https://vettabase.com/blog/why-tables-need-a-primary-key-in-mariadb-and-mysql/