add an admin check for the preview max setting

[szaimen]

Signed-off-by: szaimen [email protected]

[szaimen]

From https://github.com/pulsejet/memories/wiki/Configuration#preview-storage-considerations

[jancborchardt]

Considering what @skjnldsv said:

We generate power of four, so 64, 256, 1024, 4096.
And we round up to the value above. #12166
1920x1080 would return a 4k image

I would say it makes sense to:

we add one extra step 2048 between 1k and 4k (1024, 2048 and 4096)

Especially since 1920*1080 is by far the most used resolution on desktop worldwide: https://gs.statcounter.com/screen-resolution-stats/desktop/worldwide
So we should cover that for sure, as on desktop that value would be most important to generate – especially as some others would also fall into that?

---

And the wording I would adjust additionally to what @Pytal said:

"Your max preview size settings are lower than 4K. Image previews may appear blurry to some users."

To this – mostly adjust "users" → "people" and specify the reason. Also, it should not be a warning but more of an "info"-level notice.

"Your max preview size settings are lower than 4K. Image previews may appear blurry to people using 4K screens."

---

Design team requested 4096, I adjusted the PR

Just for the record since there might have been a misunderstanding – it was not really a request, but based on @nimishavijay’s thumbs up on this comment, right? #31938 (comment)

[skjnldsv]

I would say it makes sense to:

we add one extra step 2048 between 1k and 4k (1024, 2048 and 4096)

Especially since 1920*1080 is by far the most used resolution on desktop worldwide: gs.statcounter.com/screen-resolution-stats/desktop/worldwide So we should cover that for sure, as on desktop that value would be most important to generate – especially as some others would also fall into that?

No, this is very different from that PR and has been discussed/addressed before.
Feel free to handle this in another issue/PR 👍

[skjnldsv]

Please let get this in

[kesselb]

Another setup check people complain about 😞

What's the rational to have a configuration option when you see a warning with a different value?

Picking a lower value for preview_max_x / preview_max_y is a common "trick" to reduce the disk usage for previews.

[szaimen]

Conflicts

[jospoortvliet]

The whole issue with some previews being bigger than the original (when it's HEIC) really shows it's not the right approach, I would say.

As it's meant to be a 'preview', it seems to make more sense to limit the size to something truly preview-territory like 1080P as Jan suggested and make sure viewers start loading the original after they loaded the preview. I believe the mobile apps already do this?