Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak tests to include shareapi_restrict_user_enumeration_full_match_userid #31927

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Tweak tests to include shareapi_restrict_user_enumeration_full_match_userid #31927

merged 1 commit into from
Apr 12, 2022

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Apr 11, 2022 •
edited
Loading

Fix tests after #31857

@artonge artonge added the 2. developing Work in progress label Apr 11, 2022
@artonge artonge added this to the Nextcloud 24 milestone Apr 11, 2022
@artonge artonge self-assigned this Apr 11, 2022
@artonge artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 11, 2022
@artonge artonge requested review from blizzz, a team, PVince81 and come-nc and removed request for a team April 11, 2022 12:51
@PVince81
Copy link
Member

can you also add a test to validate that this setting works when enabled/disabled ?

PVince81
PVince81 approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 let's merge as it fixes CI, please add the tests separately

@PVince81 PVince81 merged commit 4626bfb into master Apr 12, 2022
@PVince81 PVince81 deleted the feat/dont_match_userid_tests branch April 12, 2022 07:43
@juliusknorr juliusknorr mentioned this pull request Apr 12, 2022
Merged
@blizzz blizzz mentioned this pull request Apr 13, 2022
Merged
@artonge artonge mentioned this pull request May 10, 2022
Merged
@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@PVince81 PVince81 PVince81 approved these changes

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
4 participants
@artonge @PVince81 @blizzz @skjnldsv