Ensure string column limit of 4.000 characters

[nickvergessen]

https://docs.oracle.com/en/database/oracle/oracle-database/19/refrn/datatype-limits.html#GUID-963C79C9-9303-49FE-8F2D-C8AAF04D3095

Signed-off-by: Joas Schilling [email protected]

[blizzz]

Column "oc_external_config"."value" is type String, but exceeding the 4.000 length limit.

PHP Fatal error:
Uncaught Error: Class 'OCA\Files_External\Tests\Command\CommandTest' not found in
/drone/src/apps/files_external/tests/Command/ApplicableTest.php:31

also

Column "oc_ldap_user_mapping"."ldap_dn" is type String, but exceeding the 4.000 length limit.

[nickvergessen]

🍿

[tcitworld]

List of apps that are concerned that I could find:

• weather Column "oc_weather_config"."value" (possibly more)
• fulltextsearch Column "oc_fulltextsearch_indexes"."message" (possibly more)
• forms New DB-Limit on String Length forms#1152
• bookmarks NC24: InvalidArgumentException: Column "oc_bookmarks"."url" is type String, but exceeding the 4.000 length limit. bookmarks#1785

[marcelklehr]

This breaking change should be listed in #29914

Also, it would be nice if apps could opt out of supporting Oracle. There have been multiple "Oracle cannot do X" issues lately, which are really annoying to work around, IMHO.

[nickvergessen]

Also, it would be nice if apps could opt out of supporting Oracle.

You can already by specifying the supported databases, e.g.
https://github.com/nextcloud/twofactor_webauthn/blob/27977e5ffef14f2d280628ff51c4728e300d8a1d/appinfo/info.xml#L20-L22
But we really recommend to instead aim for supporting all databases

This breaking change should be listed in #29914

We can list it of course, but it is not new in theory. It errored before already on Oracle. If you install the app with a github action on Oracle it should show imediately.
See https://github.com/nextcloud/app-tutorial/blob/master/.github/workflows/phpunit-oci.yml for example code

[marcelklehr]

It errored before already on Oracle.

I didn't even know I had to support Oracle, until these issues crept up.

<database>sqlite</database>
<database>mysql</database>
<database>pgsql</database>

Is a nice fix, didn't know this was possible. Thanks :)

[marcelklehr]

I still get this error, though, even when excluding oracle as a dependency.

https://github.com/nextcloud/bookmarks/runs/5807151749

[skjnldsv]

I still get this error, though, even when excluding oracle as a dependency.
nextcloud/bookmarks/runs/5807151749

@marcelklehr
#31872

[marcelklehr]

My issue was fixed by #31825 already :)