Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add password reset typed events and modernize LostController #31637

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Add password reset typed events and modernize LostController #31637

merged 3 commits into from
Jun 13, 2022

Conversation

tcitworld
Copy link
Member

No description provided.

@tcitworld tcitworld added enhancement 3. to review Waiting for reviews feature: authentication technical debt php Pull requests that update Php code labels Mar 21, 2022
@tcitworld tcitworld added this to the Nextcloud 24 milestone Mar 21, 2022
@tcitworld tcitworld force-pushed the add-password-reset-typed-events branch 3 times, most recently from 3aa3728 to 7363ce3 Compare March 21, 2022 09:13
@tcitworld tcitworld force-pushed the add-password-reset-typed-events branch from 7363ce3 to 3e3114b Compare March 22, 2022 08:53
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
Merged
@blizzz blizzz mentioned this pull request Mar 31, 2022
Merged
This was referenced Apr 7, 2022
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
@tcitworld tcitworld force-pushed the add-password-reset-typed-events branch from 3e3114b to a2f0ed0 Compare May 12, 2022 16:27
PVince81
PVince81 approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code looks fine to me, please adjust the @since for 25

@tcitworld
Add password reset typed events
44e1384 
These hooks are only used in the Encryption app from what I can see.

Signed-off-by: Thomas Citharel <[email protected]>
@tcitworld
Modernize the LostControllerTest test
6283d14 
Remove some depreciated at() calls

Signed-off-by: Thomas Citharel <[email protected]>
@tcitworld
Make LostController use IInitialState and LoggerInterface
abe5ff3 
Signed-off-by: Thomas Citharel <[email protected]>
@tcitworld tcitworld force-pushed the add-password-reset-typed-events branch from a2f0ed0 to abe5ff3 Compare June 10, 2022 14:42
@tcitworld
Copy link
Member Author

Adjusted and rebased.

@PVince81 PVince81 merged commit 12e3e85 into master Jun 13, 2022
@PVince81 PVince81 deleted the add-password-reset-typed-events branch June 13, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@PVince81 PVince81 PVince81 approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement feature: authentication php Pull requests that update Php code technical debt
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
5 participants
@tcitworld @nickvergessen @PVince81 @come-nc @blizzz