Stop adding passwords to passwordless authtokens during updatePasswords()

[mdoggydog]

Fixes #30894 (at least, it is supposed to).

Signed-off-by: Matt Marjanovic [email protected]

[ChristophWurst]

I'm not entirely sure if we want passwordless tokens to remain passwordless. IIRC the idea once was that by injecting a password from another login these token upgrade to a full-fledged token that also works with external storage and friends.

[CarlSchwan]

Fix some bugs

[CarlSchwan]

/backport to stable24

[CarlSchwan]

/backport to stable23

[CarlSchwan]

/backport to stable22

[CarlSchwan]

Actually, @ChristophWurst is right, this might cause some issues in case some user is using the clients to access external resources

@mdoggydog Could you test if this PR also solves your issue? #33110 you will need to set the 'auth.storeCryptedPassword' option in your config.php to false

[mdoggydog]

Actually, @ChristophWurst is right, this might cause some issues in case some user is using the clients to access external resources

Yes, I see that now. Originally I was only considering that captured passwords were used for access to email services --- and did not see any reason for an authtoken for an app to need to facilitate email access. I didn't consider external storage.

@mdoggydog Could you test if this PR also solves your issue? #33110 you will need to set the 'auth.storeCryptedPassword' option in your config.php to false

I'm not sure that this will help, because this would prevent all authtokens from storing captured passwords ...which would prevent capturing passwords needed for access to external email accounts, right? As @ChristophWurst alluded to in #30894 (comment), the real problem here is likely other bugs in the authtoken managment; this PR and #33110 provide detours around those bugs, but don't actually fix them. (I still need to respond to his comments there.)

For what it's worth, I do think being able to turn off password capture altogether is great. It is good to be able to ensure that capture will never happen unintentionally (if one knows the password-capture mechanism should never be needed on a particular NC instance).

I will try to try out #33110 later this week; I need to think about a way to experiment without invalidating everyone's authtokens (which is incredibly annoying to everyone).

[skjnldsv]

I will try to try out #33110 later this week; I need to think about a way to experiment without invalidating everyone's authtokens (which is incredibly annoying to everyone).

Any news? :)

If not, as there is no feedback since a while, I will close this ticket:see_no_evil:
If you will decide to work on this feature again and if it hasn't been fixed or implemented already, feel free to rebase and solve the various conflicts.

Thanks for the interest in Nextcloud and the effort put into this! 🙇

[skjnldsv]

Closing this pull request due to lack of recent activity and updates. We appreciate your contribution and encourage you to reopen or provide further updates if necessary. ☺️
Our aim is to keep the project moving forward with active collaboration. Thank you for your understanding and continued support! 🙏