Fix bad request when creating users without a password #30649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the minimal password length is set to 0, the generated password by `GenerateSecurePasswordEvent` is '', which would bypass the fallback password generation. `UserManager` would then throw an error since the password is an empty string. Signed-off-by: Dany Jupille <[email protected]>
szaimen
requested review from
a team,
nickvergessen,
icewind1991 and
CarlSchwan
and removed request for
a team
|
Could also fix the password policy app to generate a non-empty password when being asked |
I also think this is the best solution. Either not allow empty password policies or make an empty password policy still generate a password with a few characters |
Merged
Merged
|
fixed in the password policy app: nextcloud/password_policy#356 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #30241, here is a pull-request containing the suggested
changes.
Commit summary:
When the minimal password length is set to 0, the generated password by
GenerateSecurePasswordEventis '', which would bypass the fallbackpassword generation.
UserManagerwould then throw an error since thepassword is an empty string.