Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable21] Remove iconv from dependencies and tests #30521

Merged
merged 1 commit into from
Jan 7, 2022
Merged

[stable21] Remove iconv from dependencies and tests #30521

merged 1 commit into from
Jan 7, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jan 7, 2022 •
edited by MichaIng
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #30515

@backportbot-nextcloud backportbot-nextcloud bot added the pending documentation This pull request needs an associated documentation update label Jan 7, 2022
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 21.0.8 milestone Jan 7, 2022
@MichaIng
Copy link
Member

MichaIng commented Jan 7, 2022 •
edited
Loading

Documentantion change: nextcloud/documentation#7866

MichaIng
MichaIng requested changes Jan 7, 2022
View reviewed changes
Copy link
Member

@MichaIng MichaIng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolving conflicts.
EDIT: Done

Test fails due to outstanding Psalm baseline update.

@MichaIng MichaIng mentioned this pull request Jan 7, 2022
Merged
@MichaIng
[stable22] Remove iconv from dependencies and tests
768bf3c 
which is not used anymore since: #29470

Signed-off-by: MichaIng <[email protected]>
@blizzz blizzz changed the title [stable21] [stable22] Remove iconv from dependencies and tests [stable21] Remove iconv from dependencies and tests Jan 7, 2022
@MichaIng MichaIng merged commit 5eb791a into stable21 Jan 7, 2022
@MichaIng MichaIng deleted the backport/30515/stable21 branch January 7, 2022 11:25
This was referenced Jan 20, 2022
Merged
Merged
@nickvergessen nickvergessen removed the pending documentation This pull request needs an associated documentation update label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaIng MichaIng MichaIng approved these changes

@blizzz blizzz blizzz approved these changes

@come-nc come-nc Awaiting requested review from come-nc

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nextcloud 21.0.8
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaIng @blizzz @nickvergessen