-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove iconv from dependencies and tests #29958
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaIng
added
pending documentation
This pull request needs an associated documentation update
dependencies
and removed
dependencies
labels
Nov 29, 2021
come-nc
approved these changes
Nov 29, 2021
CarlSchwan
approved these changes
Nov 29, 2021
/backport to stable21 |
/backport to stable22 |
/backport to stable23 |
Let me create backports for #29470 first. |
MichaIng
force-pushed
the
fix/translit-php8/deps-and-tests
branch
2 times, most recently
from
November 29, 2021 23:48
b159b58
to
01d1a33
Compare
which is not used anymore since: #29470 Signed-off-by: MichaIng <[email protected]>
MichaIng
force-pushed
the
fix/translit-php8/deps-and-tests
branch
from
November 30, 2021 01:33
01d1a33
to
0d749b7
Compare
The backport to stable21 failed. Please do this backport manually. |
The backport to stable22 failed. Please do this backport manually. |
The backport to stable23 failed. Please do this backport manually. |
MichaIng
added a commit
that referenced
this pull request
Dec 20, 2021
as of: #29470 Some tests were missing in: #29958 Signed-off-by: MichaIng <[email protected]>
MichaIng
added a commit
to nextcloud/documentation
that referenced
this pull request
Dec 20, 2021
The usage of iconv has been removed in: nextcloud/server#29470 The dependency has been removed in: nextcloud/server#29958 Signed-off-by: MichaIng <[email protected]>
Related documentation change is proposed here: nextcloud/documentation#7860 |
backportbot-nextcloud bot
pushed a commit
to nextcloud/documentation
that referenced
this pull request
Dec 20, 2021
The usage of iconv has been removed in: nextcloud/server#29470 The dependency has been removed in: nextcloud/server#29958 Signed-off-by: MichaIng <[email protected]>
backportbot-nextcloud bot
pushed a commit
to nextcloud/documentation
that referenced
this pull request
Dec 20, 2021
The usage of iconv has been removed in: nextcloud/server#29470 The dependency has been removed in: nextcloud/server#29958 Signed-off-by: MichaIng <[email protected]>
backportbot-nextcloud bot
pushed a commit
to nextcloud/documentation
that referenced
this pull request
Dec 20, 2021
The usage of iconv has been removed in: nextcloud/server#29470 The dependency has been removed in: nextcloud/server#29958 Signed-off-by: MichaIng <[email protected]>
MichaIng
added a commit
that referenced
this pull request
Dec 31, 2021
as of: #29470 Some tests were missing in: #29958 Signed-off-by: MichaIng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
pending documentation
This pull request needs an associated documentation update
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which is not used anymore since: #29470
When accepted, requires an update of the documentation which I'll then commit as well.