Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iconv from dependencies and tests #29958

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

MichaIng
Copy link
Member

@MichaIng MichaIng commented Nov 29, 2021

which is not used anymore since: #29470

When accepted, requires an update of the documentation which I'll then commit as well.

@MichaIng MichaIng added the 3. to review Waiting for reviews label Nov 29, 2021
@MichaIng MichaIng added this to the Nextcloud 24 milestone Nov 29, 2021
@MichaIng MichaIng added pending documentation This pull request needs an associated documentation update dependencies and removed dependencies labels Nov 29, 2021
@CarlSchwan
Copy link
Member

/backport to stable21

@CarlSchwan
Copy link
Member

/backport to stable22

@CarlSchwan
Copy link
Member

/backport to stable23

@MichaIng
Copy link
Member Author

Let me create backports for #29470 first.

@MichaIng MichaIng force-pushed the fix/translit-php8/deps-and-tests branch 2 times, most recently from b159b58 to 01d1a33 Compare November 29, 2021 23:48
which is not used anymore since: #29470

Signed-off-by: MichaIng <[email protected]>
@MichaIng MichaIng force-pushed the fix/translit-php8/deps-and-tests branch from 01d1a33 to 0d749b7 Compare November 30, 2021 01:33
@MichaIng MichaIng merged commit d16d4d3 into master Nov 30, 2021
@MichaIng MichaIng deleted the fix/translit-php8/deps-and-tests branch November 30, 2021 12:07
@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

MichaIng added a commit that referenced this pull request Dec 20, 2021
as of: #29470

Some tests were missing in: #29958

Signed-off-by: MichaIng <[email protected]>
MichaIng added a commit to nextcloud/documentation that referenced this pull request Dec 20, 2021
The usage of iconv has been removed in: nextcloud/server#29470

The dependency has been removed in: nextcloud/server#29958

Signed-off-by: MichaIng <[email protected]>
@MichaIng
Copy link
Member Author

MichaIng commented Dec 20, 2021

Related documentation change is proposed here: nextcloud/documentation#7860

backportbot-nextcloud bot pushed a commit to nextcloud/documentation that referenced this pull request Dec 20, 2021
The usage of iconv has been removed in: nextcloud/server#29470

The dependency has been removed in: nextcloud/server#29958

Signed-off-by: MichaIng <[email protected]>
backportbot-nextcloud bot pushed a commit to nextcloud/documentation that referenced this pull request Dec 20, 2021
The usage of iconv has been removed in: nextcloud/server#29470

The dependency has been removed in: nextcloud/server#29958

Signed-off-by: MichaIng <[email protected]>
backportbot-nextcloud bot pushed a commit to nextcloud/documentation that referenced this pull request Dec 20, 2021
The usage of iconv has been removed in: nextcloud/server#29470

The dependency has been removed in: nextcloud/server#29958

Signed-off-by: MichaIng <[email protected]>
MichaIng added a commit that referenced this pull request Dec 31, 2021
as of: #29470

Some tests were missing in: #29958

Signed-off-by: MichaIng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants