Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add illustrator icon #29642

Closed
wants to merge 2 commits into from
Closed

Add illustrator icon #29642

wants to merge 2 commits into from

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Nov 10, 2021

Close #24861

Signed-off-by: szaimen [email protected]

For my own testing
docker run -it \
-e SERVER_BRANCH=enh/noid/add-illustrator-icon \
-e PDFVIEWER_BRANCH=master \
-e VIEWER_BRANCH=master \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.130 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added this to the Nextcloud 24 milestone Nov 10, 2021
@szaimen szaimen force-pushed the enh/noid/add-illustrator-icon branch 4 times, most recently from 4e78e22 to 39ba9e2 Compare November 10, 2021 19:40
@szaimen
Copy link
Contributor Author

szaimen commented Nov 11, 2021

Thanks Carl but I need help fixing the following test first:
20211111_150039
Do you have any idea how to do that?

@szaimen
Copy link
Contributor Author

szaimen commented Nov 11, 2021

I've got an answer from Julius:

php occ integrity:sign-core --privateKey=./tests/data/integritycheck/core.key --certificate=./tests/data/integritycheck/core.crt --path=./tests/data/integritycheck/mimetypeListModified

and then cat ./tests/data/integritycheck/mimetypeListModified/core/signature.json

@szaimen szaimen force-pushed the enh/noid/add-illustrator-icon branch from cce3067 to 0b826b1 Compare November 11, 2021 14:33
@szaimen szaimen force-pushed the enh/noid/add-illustrator-icon branch from 0b826b1 to b433cff Compare November 17, 2021 14:55
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
@blizzz blizzz mentioned this pull request Mar 31, 2022
This was referenced Apr 7, 2022
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
@szaimen
Copy link
Contributor Author

szaimen commented Jun 7, 2022

Maay help here: #3248

This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
This was referenced May 3, 2023
@skjnldsv
Copy link
Member

skjnldsv commented May 9, 2023

Iirc this has been suggested before and we have no permission to distribute this copyrighted icon

Same for #29643

@szaimen szaimen closed this May 9, 2023
@szaimen szaimen deleted the enh/noid/add-illustrator-icon branch May 9, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a thumbnail for adobe illustrator files
4 participants