Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable21] Fix/images php 8.0 #29520

Merged
merged 5 commits into from
Nov 8, 2021
Merged

[stable21] Fix/images php 8.0 #29520

merged 5 commits into from
Nov 8, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Nov 2, 2021

backport of #29479

This makes sure using resource or GdImage (PHP>=8) behaves the same.

Signed-off-by: Côme Chilliet <[email protected]>
This reverts commit d690f90.

Signed-off-by: Côme Chilliet <[email protected]>
@skjnldsv
Copy link
Member

skjnldsv commented Nov 2, 2021

Please check this:
image

@blizzz blizzz mentioned this pull request Nov 3, 2021
10 tasks
@skjnldsv skjnldsv added the 2. developing Work in progress label Nov 4, 2021
@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 4, 2021
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to import \GdImage with the use statement and save the backslash later on.

@come-nc come-nc merged commit 5041b72 into stable21 Nov 8, 2021
@come-nc come-nc deleted the backport/29479/stable21 branch November 8, 2021 10:57
@blizzz blizzz mentioned this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants