Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guzzlehttp/guzzle requirement from 6.5.2 to 6.5.5 in /build/integration #29491

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 30, 2021

Updates the requirements on guzzlehttp/guzzle to permit the latest version.

Changelog

Sourced from guzzlehttp/guzzle's changelog.

6.5.5 - 2020-06-16

  • Unpin version constraint for symfony/polyfill-intl-idn #2678

6.5.4 - 2020-05-25

  • Fix various intl icu issues #2626

6.5.3 - 2020-04-18

  • Use Symfony intl-idn polyfill #2550
  • Remove use of internal functions #2548

6.5.2 - 2019-12-23

  • idn_to_ascii() fix for old PHP versions #2489

6.5.1 - 2019-12-21

  • Better defaults for PHP installations with old ICU lib #2454
  • IDN support for redirects #2424

6.5.0 - 2019-12-07

  • Improvement: Added support for reset internal queue in MockHandler. #2143
  • Improvement: Added support to pass arbitrary options to curl_multi_init. #2287
  • Fix: Gracefully handle passing null to the header option. #2132
  • Fix: RetryMiddleware did not do exponential delay between retries due unit mismatch. #2132 Previously, RetryMiddleware would sleep for 1 millisecond, then 2 milliseconds, then 4 milliseconds. After this change, RetryMiddleware will sleep for 1 second, then 2 seconds, then 4 seconds. Middleware::retry() accepts a second callback parameter to override the default timeouts if needed.
  • Fix: Prevent undefined offset when using array for ssl_key options. #2348
  • Deprecated ClientInterface::VERSION

6.4.1 - 2019-10-23

  • No guzzle.phar was created in 6.4.0 due expired API token. This release will fix that
  • Added parent::__construct() to FileCookieJar and SessionCookieJar

6.4.0 - 2019-10-23

  • Improvement: Improved error messages when using curl < 7.21.2 #2108
  • Fix: Test if response is readable before returning a summary in RequestException::getResponseBodySummary() #2081
  • Fix: Add support for GUZZLE_CURL_SELECT_TIMEOUT environment variable #2161
  • Improvement: Added GuzzleHttp\Exception\InvalidArgumentException #2163
  • Improvement: Added GuzzleHttp\_current_time() to use hrtime() if that function exists. #2242
  • Improvement: Added curl's appconnect_time in TransferStats #2284
  • Improvement: Make GuzzleException extend Throwable wherever it's available #2273
  • Fix: Prevent concurrent writes to file when saving CookieJar #2335
  • Improvement: Update MockHandler so we can test transfer time #2362

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team October 30, 2021 02:25
Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 30, 2021

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@MichaIng MichaIng added this to the Nextcloud 20.0.14 milestone Oct 30, 2021
@MichaIng
Copy link
Member

MichaIng commented Oct 30, 2021

I guess requires #29299 to go green.

Though Drone failure looks related, e.g.:

Fatal error: Call to undefined function GuzzleHttp\_idn_uri_convert()

@MichaIng MichaIng added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 30, 2021
Copy link
Member

@MichaIng MichaIng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related Drone error (in all 6 cases of the same test) in /drone/src/build/integration/remoteapi_features/remote.feature:

Fatal error: Call to undefined function GuzzleHttp\_idn_uri_convert()

Looks like GuzzleHttp\Utils::idnUriConvert is now the way to go: https://github.com/guzzle/guzzle/pull/2548/files

@MichaIng
Copy link
Member

MichaIng commented Oct 30, 2021

Not sure how/where to apply the fix. Same was faced and fixed in 3rdparty, but I cannot find this invalid function call in the server repo: nextcloud/3rdparty#557

Seems to have been fixed with NC21 as all tests went through nicely here: #29493

@blizzz blizzz mentioned this pull request Nov 3, 2021
15 tasks
Updates the requirements on [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) to permit the latest version.
- [Release notes](https://github.com/guzzle/guzzle/releases)
- [Changelog](https://github.com/guzzle/guzzle/blob/6.5.5/CHANGELOG.md)
- [Commits](guzzle/guzzle@6.5.2...6.5.5)

---
updated-dependencies:
- dependency-name: guzzlehttp/guzzle
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/composer/build/integration/stable20/guzzlehttp/guzzle-6.5.5 branch from 0a1d4ab to 6b084ff Compare November 15, 2021 14:51
Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@rakekniven rakekniven removed this from the Nextcloud 20.0.14 milestone Nov 19, 2021
@MichaIng
Copy link
Member

Marking as closed as NC20 is EOL.

@MichaIng MichaIng closed this Nov 21, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 21, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@MichaIng MichaIng deleted the dependabot/composer/build/integration/stable20/guzzlehttp/guzzle-6.5.5 branch November 21, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants