Revamp profile visibility section

[Pytal]

Revamp profile visibility settings by grouping dropdowns together into one section instead of one dropdown under every input field and make necessary improvements to the backend i.e. provide appId for sorting and dynamic displayId.

The design of the entire settings page is not final and this new section was placed in a separate block pending an overhaul of the layout @nextcloud/designers

Contributes to #28139

[Pytal]

Psalm errors seem unrelated 🤔

[CarlSchwan]

Psalm errors seem unrelated thinking

If you can reproduce this error locally, could you update the psalm baseline?

[CarlSchwan]

This looks so much better. Great work!

[skjnldsv]

If you can reproduce this error locally, could you update the psalm baseline?

Let's do that in another PR

[skjnldsv]

Seems super specific and new, but not related to this PR 🤔

[Pytal]

This is to make it so that clicking the "Edit your Profile visibility" anchor link scrolls smoothly to the new section instead of jumping instantly :)

[skjnldsv]

I think that will impact everything else too then? Maybe just scope that to the visibility styling?

[Pytal]

It was already attempted to set this property on the scoped container which contains the elements, but in testing it seemed that setting on html was the only way it would work. As a js solution would be suboptimal I opted to place this in the styles of the component instead so that it would ony apply on the settings page with the component

server/apps/settings/src/components/PersonalInfo/ProfileSection/EditProfileAnchorLink.vue

Lines 62 to 70 in 19c62d0

	<style lang="scss">
	html {
	scroll-behavior: smooth;
	@media screen and (prefers-reduced-motion: reduce) {
	scroll-behavior: auto;
	}
	}
	</style>

[artonge]

Indeed tricky as the scroll-behaviour has to be set on the scrolling element, and in this case, it is html.

You could wrap the personal settings into a <div>, limit its height to 100vh - $hearder-height and set the scroll-behaviour on it. But I didn't find how to include the development notice at the bottom.

In any case, setting scroll-behaviour globally could be a good change. But might need some discussion...

[artonge]

Oh, its merged already 😅

[Pytal]

In any case, setting scroll-behaviour globally could be a good change. But might need some discussion...

Yes, would have to see if any current functionality depends on non-smooth scroll-behavior, though it'd most likely be purely cosmetic 🤔

[skjnldsv]

Some comments, otherwise good! 🚀

[Pytal]

If you can reproduce this error locally, could you update the psalm baseline?

Let's do that in another PR

Pinging @https://github.com/nextcloud/server/blob/master/.github/workflows/update-psalm-baseline.yml :)

[Pytal]

/compile amend /