Fix immutable datetime handling in DAV calendar search #29481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
bug
3. to review
ChristophWurst
requested review from
nickvergessen,
PVince81 and
skjnldsv
and removed request for
a team
|
You can use |
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/dav-calendar-query-start-end-immutable
branch
from
d2b19b6
to
2956f1c
Compare
tcitworld
approved these changes
Oct 28, 2021
nickvergessen
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new API from #28970 we get immutable datetime objects. These do not extend the mutable datetime class, hence the options were silently ignored. With this patch the new calendar query API can scope by dates.