Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to restore automatic status #29430

Closed
wants to merge 7 commits into from
Closed

Add option to restore automatic status #29430

wants to merge 7 commits into from

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Oct 25, 2021 •
edited
Loading

Fix #29339

image

@CarlSchwan CarlSchwan marked this pull request as draft October 25, 2021 12:46
@CarlSchwan
Copy link
Member Author

/compile amend /

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Nov 4, 2021
@CarlSchwan CarlSchwan self-assigned this Nov 4, 2021
@CarlSchwan CarlSchwan marked this pull request as ready for review November 4, 2021 15:44
@CarlSchwan @nextcloud-command
fixup! Fix the remaining bugs
4e8141c 
Signed-off-by: nextcloud-command <[email protected]>
nickvergessen
nickvergessen reviewed Nov 4, 2021
View reviewed changes
apps/user_status/src/store/backupUserStatus.js Show resolved Hide resolved
apps/user_status/src/store/userStatus.js Show resolved Hide resolved
apps/user_status/src/components/ResetStatus.vue Outdated
Comment on lines 25 to 31
{{ $t('user_status', 'Reset to') }}
<a
href="#"
role="button"
@click.prevent.stop="revertCurrentStatus">
{{ message }}
</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per https://docs.nextcloud.com/server/latest/developer_manual/basics/front-end/l10n.html#improving-your-translations please make the message a parameter in the translation, or use another line break and make the translated string "complete" e.g. Reset status: and use a real button?

apps/user_status/appinfo/routes.php Outdated Show resolved Hide resolved
@nickvergessen
Copy link
Member

nickvergessen commented Nov 4, 2021 •
edited
Loading

Internal Server Error\nArgument 1 passed to OCA\UserStatus\Controller\UserStatusController::setPredefinedMessage() must be of the type string, null given, called in server/lib/private/AppFramework/Http/Dispatcher.php on line 217 in file 'server/apps/user_status/lib/Controller/UserStatusController.php' line 133

Not sure how I created this, it was random clicking around between status (online/away/...) and predefined statuses

@jancborchardt
Copy link
Member

This note should show below the input field for the status message though, as it's related to the message. Right?

@CarlSchwan CarlSchwan changed the title Revert automatic status Restore automatic status Nov 4, 2021
@jancborchardt
Copy link
Member

This note should show below the input field for the status message though, as it's related to the message. Right?

@CarlSchwan was that fixed? Also it seems this needs rebasing, mind updating the screenshot afterwards? :)

@PVince81
Copy link
Member

did we not fix this differently ? or have plans for it in a different context ? @CarlSchwan @nickvergessen

@nickvergessen
Copy link
Member

This would still be highly appiciated

@nickvergessen nickvergessen changed the title Restore automatic status Add option to restore automatic status Jun 13, 2022
@nickvergessen nickvergessen added this to the Nextcloud 25 milestone Jun 13, 2022
jancborchardt
jancborchardt requested changes Jun 16, 2022
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note should show below the input field for the status message though, as it's related to the message.

@skjnldsv skjnldsv mentioned this pull request Aug 12, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
This was referenced May 3, 2023
Merged
Closed
Merged
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv
Copy link
Member

cc @nickvergessen do we still need this?
also cc @ChristophWurst as it seems groupware also have meeting automated statuses

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 24, 2024
@nickvergessen
Copy link
Member

I implemented this already some time ago

@skjnldsv skjnldsv deleted the revert_automatic_status branch February 24, 2024 18:25
@skjnldsv skjnldsv removed the 2. developing Work in progress label Feb 24, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 29 milestone Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@jancborchardt jancborchardt jancborchardt requested changes

@artonge artonge Awaiting requested review from artonge

Assignees

@CarlSchwan CarlSchwan

Labels
enhancement feature: status
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing action to revert the status back after an auto change in calendar/talk
6 participants
@CarlSchwan @nickvergessen @jancborchardt @PVince81 @skjnldsv @blizzz