Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump icewind/streams from 0.7.3 to 0.7.5 in files_external #29298

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Bump icewind/streams from 0.7.3 to 0.7.5 in files_external #29298

merged 1 commit into from
Oct 19, 2021

Conversation

PVince81
Copy link
Member

@PVince81 PVince81 commented Oct 18, 2021 •
edited
Loading

@PVince81 PVince81 added the 3. to review Waiting for reviews label Oct 18, 2021
@PVince81 PVince81 self-assigned this Oct 18, 2021
@PVince81 PVince81 mentioned this pull request Oct 18, 2021
Closed
CarlSchwan
CarlSchwan approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the psalm baseline needs to be updated since there is now less warnings :D

@PVince81
Copy link
Member Author

I did a quick smoke test with minio and S3 worked fine and I saw no fclose messages.

@PVince81 PVince81 merged commit 3ca183d into stable20 Oct 19, 2021
@PVince81 PVince81 deleted the files-external-icewind-streams-0.7.5-stable20 branch October 19, 2021 12:43
@blizzz blizzz mentioned this pull request Nov 3, 2021
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@kesselb kesselb Awaiting requested review from kesselb

@artonge artonge Awaiting requested review from artonge

Assignees

@PVince81 PVince81

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PVince81 @skjnldsv @CarlSchwan