Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for group mentions in talk (and comments?) #29140

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 8, 2021

Prerequirement for nextcloud/spreed#6339

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen added this to the Nextcloud 23 milestone Oct 8, 2021
@nickvergessen nickvergessen requested review from blizzz, a team, PVince81 and skjnldsv and removed request for a team October 8, 2021 11:24
Copy link
Contributor

@vitormattos vitormattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the regular expression is already big, it's good to have unit test with possible match scenarios

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Copy link
Member Author

Tests are already there and are now extended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants