Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable21] file-upload: Correctly handle error responses for HTTP2 #29068

Merged
merged 1 commit into from
Oct 6, 2021
Merged

[stable21] file-upload: Correctly handle error responses for HTTP2 #29068

merged 1 commit into from
Oct 6, 2021

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Oct 4, 2021

Backport of #25569

Signed-off-by: Jakub Onderka [email protected]

@kesselb kesselb added bug 3. to review Waiting for reviews labels Oct 4, 2021
@kesselb kesselb added this to the Nextcloud 21.0.6 milestone Oct 4, 2021
@kesselb kesselb requested review from a team, PVince81, artonge and szaimen and removed request for a team October 4, 2021 16:53
@kesselb kesselb self-assigned this Oct 4, 2021
@artonge
Copy link
Contributor

artonge commented Oct 5, 2021

Static code analysis / static-code-analysis (pull_request) Failing after 2m — static-code-analysis :

5 errors fixed
Error: Method OCP\DB\QueryBuilder\IQueryBuilder::executeQuery does not exist
Error: Method OCP\DB\QueryBuilder\IQueryBuilder::executeStatement does not exist
Script psalm handling the psalm event returned with error code 1

Weird stuff considering this is a one line change

@kesselb
Copy link
Contributor Author

kesselb commented Oct 5, 2021

#29074 should fix CI for stable21.

@kesselb kesselb merged commit 0de39c7 into stable21 Oct 6, 2021
@kesselb kesselb deleted the backport/stable21/25569 branch October 6, 2021 06:46
@blizzz blizzz mentioned this pull request Nov 3, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@artonge artonge Awaiting requested review from artonge

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@kesselb kesselb

Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 21.0.6
Development

Successfully merging this pull request may close these issues.
4 participants
@kesselb @artonge @Pytal @JakubOnderka