Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix files view change and undefined currentFileList #28872

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Fix files view change and undefined currentFileList #28872

merged 1 commit into from
Sep 17, 2021

Conversation

skjnldsv
Copy link
Member

Fix #26672

Steps

  1. Favourite a file
  2. Go to favourites
  3. Open file menu and click "View in folder"
  4. Try to create a file

Explanations

Because the change is set to silent, we don't emit the jQuery event to dispatch the view change.
So the app is not fully instantiated on the new view.

server/apps/files/js/navigation.js

Lines 153 to 168 in f13b3ab

if (!options || !options.silent) {
this.$currentContent.trigger(jQuery.Event('show', {
itemId: itemId,
previousItemId: oldItemId,
dir: itemDir,
view: itemView
}));
this.$el.trigger(
new $.Event('itemChanged', {
itemId: itemId,
previousItemId: oldItemId,
dir: itemDir,
view: itemView
})
);
}

@skjnldsv skjnldsv added this to the Nextcloud 23 milestone Sep 17, 2021
@skjnldsv skjnldsv requested a review from a team September 17, 2021 08:44
@skjnldsv skjnldsv self-assigned this Sep 17, 2021
@skjnldsv skjnldsv requested review from PVince81, artonge and szaimen and removed request for a team September 17, 2021 08:44
@skjnldsv
Copy link
Member Author

/backport to stable22

@skjnldsv
Copy link
Member Author

/backport to stable21

@skjnldsv
Copy link
Member Author

/backport to stable20

@skjnldsv skjnldsv requested a review from Pytal September 17, 2021 08:44
@skjnldsv skjnldsv mentioned this pull request Sep 17, 2021
Closed
PVince81
PVince81 approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Pytal
Copy link
Member

Pytal commented Sep 17, 2021

⚙ failure unrelated

@Pytal Pytal merged commit b033d57 into master Sep 17, 2021
@Pytal Pytal deleted the fix/files-view-undefined-currentFileList branch September 17, 2021 19:52
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 17, 2021
This was referenced Sep 17, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@PVince81 PVince81 PVince81 approved these changes

@artonge artonge Awaiting requested review from artonge

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.

Alert “Unable to create new file from template”
3 participants
@skjnldsv @Pytal @PVince81