Add navigation via info.xml (#26785) #2822
Conversation
* Read navigation information from info.xml * Load files navigation elements from info.xml * Add comment about ignoring the exception Signed-off-by: Lukas Reschke <[email protected]>
|
@LukasReschke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @bartv2 and @MorrisJobke to be potential reviewers. |
LukasReschke
requested review from
rullzer,
nickvergessen,
MorrisJobke and
schiessle
| <navigation> | ||
| <route>files.view.index</route> | ||
| <order>0</order> | ||
| </navigation> |
There was a problem hiding this comment.
Once merged requires to be added to https://github.com/nextcloud/appstore/blob/master/nextcloudappstore/core/api/v1/release/info.xsd as well.
There was a problem hiding this comment.
What I dislike about this is it drops the name tag by default, uses firstCaseUpper(appname). I think it's a trap for apps which then will accidently not have this translated anymore.
There was a problem hiding this comment.
Also this looks like an app can only have one? Should we wrap it in a "navigations" so we can have muliple?
Or should those apps just use the programmatic way then instead?
There was a problem hiding this comment.
What I dislike about this is it drops the name tag by default, uses firstCaseUpper(appname). I think it's a trap for apps which then will accidently not have this translated anymore.
We should probably work on getting our CI scripts running then in a way that it supports the lang= tag as seen at http://nextcloudappstore.readthedocs.io/en/latest/developer.html#info-xml
There was a problem hiding this comment.
Can also adjust the travis thing to translate <navigation><name> when its provided?
There was a problem hiding this comment.
@MorrisJobke can we add this simply? Extracting <navigation><name> automatically to travis?
There was a problem hiding this comment.
@MorrisJobke can we add this simply? Extracting automatically to travis?
Create me a ticket - I will look into extending it 😉
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
| <svg xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns="http://www.w3.org/2000/svg" height="32" width="32" version="1.1" xmlns:cc="http://creativecommons.org/ns#" xmlns:dc="http://purl.org/dc/elements/1.1/"> | |||
There was a problem hiding this comment.
no viewbox no minification
| <navigation> | ||
| <route>files.view.index</route> | ||
| <order>0</order> | ||
| </navigation> |
There was a problem hiding this comment.
Also this looks like an app can only have one? Should we wrap it in a "navigations" so we can have muliple?
Or should those apps just use the programmatic way then instead?
Signed-off-by: Morris Jobke <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Read navigation information from info.xml
Load files navigation elements from info.xml
Add comment about ignoring the exception
From owncloud/core#26785