Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Audit - Sharing: createShare - report the full path #28075

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Admin Audit - Sharing: createShare - report the full path #28075

merged 1 commit into from
Jul 26, 2021

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jul 20, 2021 •
edited
Loading

As the Admin of a Nextcloud instance, I want to see the full path to a file/folder that is shared in the admin audit log and not the theoretical position where the file/folder might be found after sharing. Beeing able to see the full path is a much more useful information because you can much better see where the file/folder is initialy located.

Signed-off-by: szaimen [email protected]

@szaimen szaimen added the 2. developing Work in progress label Jul 20, 2021
@szaimen szaimen force-pushed the enh/noid/admin_audit-report-full-path branch 18 times, most recently from 493bf85 to 4f364ca Compare July 21, 2021 13:54
@szaimen szaimen changed the title Try to implement reporting the full path Admin Audit - Sharing: createShare - report the full path Jul 21, 2021
@szaimen szaimen marked this pull request as ready for review July 21, 2021 14:06
@szaimen szaimen added 3. to review Waiting for reviews enhancement feature: admin audit and removed 2. developing Work in progress labels Jul 21, 2021
@szaimen szaimen added this to the Nextcloud 23 milestone Jul 21, 2021
@szaimen szaimen requested a review from wiswedel July 21, 2021 14:09
@szaimen
Copy link
Contributor Author

szaimen commented Jul 21, 2021

Failing test is unrelated

@szaimen
Copy link
Contributor Author

szaimen commented Jul 22, 2021

/rebase

@github-actions github-actions bot force-pushed the enh/noid/admin_audit-report-full-path branch from 4f364ca to 4570bb4 Compare July 22, 2021 14:20
@szaimen szaimen closed this Jul 24, 2021
@szaimen szaimen reopened this Jul 24, 2021
@juliusknorr
Copy link
Member

Failure unrelated

@juliusknorr juliusknorr merged commit b31c08e into master Jul 26, 2021
@juliusknorr juliusknorr deleted the enh/noid/admin_audit-report-full-path branch July 26, 2021 10:35
@szaimen
Copy link
Contributor Author

szaimen commented Jul 26, 2021

/backport to stable22

@juliusknorr
Copy link
Member

I'd vote against backports since external log parsing might require adjustments through the changed format.

@szaimen
Copy link
Contributor Author

szaimen commented Jul 26, 2021

I'd vote against backports since external log parsing might require adjustments through the changed format.

Thats a good point but what about backporting to stable22?

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Jul 26, 2021

/backport to stable22

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 26, 2021
Merged
@juliusknorr
Copy link
Member

Fine by me since it will be 21.1, but would be good to add to #27846 as a note

@szaimen szaimen mentioned this pull request Jul 26, 2021
Closed
@szaimen
Copy link
Contributor Author

szaimen commented Jul 26, 2021

but would be good to add to #27846 as a note

Added it under Behavorial changes

Do we have somethings like this for 22.1, too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

@kesselb kesselb Awaiting requested review from kesselb

@wiswedel wiswedel Awaiting requested review from wiswedel

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement feature: admin audit
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
3 participants
@szaimen @juliusknorr @skjnldsv