Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable20] Fix mimetype and mindmap icon #27989

Closed
wants to merge 1 commit into from
Closed

Conversation

skjnldsv
Copy link
Member

Signed-off-by: John Molakvoæ (skjnldsv) [email protected]

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv marked this pull request as ready for review July 16, 2021 07:02
@skjnldsv skjnldsv requested review from artonge and blizzz July 16, 2021 07:05
@skjnldsv skjnldsv added 3. to review Waiting for reviews bug labels Jul 16, 2021
@skjnldsv skjnldsv added this to the Nextcloud 20.0.12 milestone Jul 16, 2021
@skjnldsv skjnldsv changed the title Fix mimetype and mindmap icon [stable20] Fix mimetype and mindmap icon Jul 16, 2021
@skjnldsv skjnldsv mentioned this pull request Jul 26, 2021
11 tasks
@skjnldsv skjnldsv mentioned this pull request Aug 3, 2021
9 tasks
@nickvergessen
Copy link
Member

There was 1 failure:

1) Test\IntegrityCheck\CheckerTest::testVerifyCoreSignatureWithModifiedMimetypelistSignatureData
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
-Array &0 ()
+Array &0 (
+    'FILE_MISSING' => Array &1 (
+        'mimetypelist.js' => Array &2 (
+            'expected' => 'dc48de7ad4baa030c5e563350c9a80b274bad783f6f5adbf1595ecef6c6a32e52890a24cb26cddb0aa20193ba52c001150c68d8bfb567f0aed566f4029a190a3'
+            'current' => ''
+        )
+    )
+    'EXTRA_FILE' => Array &3 (
+        'core/js/mimetypelist.js' => Array &4 (
+            'expected' => ''
+            'current' => '23a3fa45757b26795f5cf8f94d9e5bce76fc916288a6458679311b312c167adcf4158ccb2c5c3db791fa0b87703b6c5863afb6c9d790b8cbac5ab3ae8c3418fb'
+        )
+    )
+)

/drone/src/tests/lib/IntegrityCheck/CheckerTest.php:1024

@skjnldsv

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 31, 2021
@blizzz blizzz mentioned this pull request Sep 23, 2021
8 tasks
@blizzz blizzz mentioned this pull request Nov 3, 2021
15 tasks
@blizzz
Copy link
Member

blizzz commented Nov 10, 2021

closing for it won't make it into the next and last 20 release anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants