Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Validator infrastructure #27961

Closed
wants to merge 10 commits into from
Closed

Add Validator infrastructure #27961

wants to merge 10 commits into from

Commits on Mar 10, 2022

  1. Fix IDN domain name not being allowed 

    The filter_var function is unfortunately not perfect and doesn't support
domain with unicode as well as url with underscores. Replace usage with
a regex from Symfony validator.

See https://bugs.php.net/search.php?cmd=display&search_for=FILTER_VALIDATE_URL

Closes #27906

Signed-off-by: Carl Schwan <[email protected]>
    @szaimen
    szaimen committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    7e6b882 View commit details
    Browse the repository at this point in the history

  2. Add an validator service with various constraints 

    The API is heavily inspired by Symfony validator while having a much
simpler implementation since this doesn't do object validation with
annotation.

Signed-off-by: Carl Schwan <[email protected]>
    @CarlSchwan @szaimen
    CarlSchwan authored and szaimen committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    0031bfb View commit details
    Browse the repository at this point in the history

  3. Add missing copyright 

    Signed-off-by: Carl Schwan <[email protected]>
    @CarlSchwan @szaimen
    CarlSchwan authored and szaimen committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    9003fd1 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from review 

    Signed-off-by: Carl Schwan <[email protected]>
    @CarlSchwan @szaimen
    CarlSchwan authored and szaimen committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    72294f4 View commit details
    Browse the repository at this point in the history

  5. add validator to setup check 

    Signed-off-by: szaimen <[email protected]>
    @szaimen
    szaimen committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    27104b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Merge constraint and validator 

    This simplifies the code a bit and make it possible for apps to add
their own validators

Signed-off-by: Carl Schwan <[email protected]>
    @CarlSchwan
    CarlSchwan committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    5751e9d View commit details
    Browse the repository at this point in the history

  2. fixup! Merge constraint and validator

    @CarlSchwan
    CarlSchwan committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    2176988 View commit details
    Browse the repository at this point in the history

  3. fixup! Merge constraint and validator

    @CarlSchwan
    CarlSchwan committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    0bcae13 View commit details
    Browse the repository at this point in the history

  4. fixup! Merge constraint and validator

    @CarlSchwan
    CarlSchwan committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    ec67ee4 View commit details
    Browse the repository at this point in the history

  5. fixup! Merge constraint and validator

    @CarlSchwan
    CarlSchwan committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    df30b14 View commit details
    Browse the repository at this point in the history