Fix for #26526 #27731
Merged
Fix for #26526 #27731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for sql query replaced double quotes with single quotes. Query should now also work for dbs with sql_mode including "ANSI" and "ANSI_QUOTES"
juliusknorr
approved these changes
Jul 1, 2021
artonge
approved these changes
Jul 1, 2021
|
Nice and quick to review, thanks @ZitronePlus ! |
|
Can you sign your commit ? git commit --amend --no-edit --signoff
git push --force-with-lease origin master |
ZitronePlus
force-pushed
the
master
branch
4 times, most recently
from
5d32f37
to
5e02ac2
Compare
fix for sql query replaced double quotes with single quotes. Query should now also work for dbs with sql_mode including "ANSI" and "ANSI_QUOTES" Signed-off-by: Tobias <[email protected]>
Pytal
approved these changes
Jul 1, 2021
|
There are two commits now, you may want to git reset --soft HEAD~2
git commit --signoff -m '<Your message>'
git push --force-with-lease origin master |
|
/rebase |
skjnldsv
added
4. to release
szaimen
added
2. developing
|
@ZitronePlus any update here? |
|
/rebase |
Merged
|
@ZitronePlus please rebase or allow us to edit this pr :) |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #26526
fix for sql query
replaced double quotes with single quotes.
Query should now also work for dbs with sql_mode including "ANSI" and "ANSI_QUOTES"