Use search to get versions list from cache for expiry #27637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
version-expire-search
branch
from
a425a01
to
e246126
Compare
juliusknorr
approved these changes
Jun 29, 2021
skjnldsv
approved these changes
Aug 18, 2021
|
Please rebase :) |
skjnldsv
added
4. to release
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
version-expire-search
branch
from
e246126
to
c3fb5ac
Compare
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
version-expire-search
branch
from
c3fb5ac
to
5f101d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of traversing the filesystem, get the list from cache.
Future improvement would be changing the mtime of the version files to the version data, which would make getting all expired ones easy and cheap. But that requires a migration step so is a bit more involved.