Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of DateTime constants #27635

Merged
merged 2 commits into from
Jun 23, 2021
Merged

Fix usage of DateTime constants #27635

merged 2 commits into from
Jun 23, 2021

Conversation

ChristophWurst
Copy link
Member

In PHP7.2 those were moved to the interface. The DateTime class doesn't actually have them anymore.

@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Jun 23, 2021
@ChristophWurst ChristophWurst added this to the Nextcloud 23 milestone Jun 23, 2021
@ChristophWurst ChristophWurst self-assigned this Jun 23, 2021
julien-nc
julien-nc approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankfully the old one still works in PHP>=7.2 😁.

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 23, 2021
Pytal
Pytal approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📅

@Pytal Pytal merged commit 9ed379d into master Jun 23, 2021
@Pytal Pytal deleted the fix/datetime-constants branch June 23, 2021 16:56
@blizzz blizzz mentioned this pull request Jun 23, 2021
Merged
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@julien-nc julien-nc julien-nc approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@artonge artonge Awaiting requested review from artonge

@solracsf solracsf Awaiting requested review from solracsf

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristophWurst @juliusknorr @julien-nc @Pytal