Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not add invalid links to the notifications #2760

Closed
wants to merge 1 commit into from
Closed

Do not add invalid links to the notifications #2760

wants to merge 1 commit into from

Conversation

nickvergessen
Copy link
Member

Steps

  1. Have an app that is outdated
  2. Have notifications and updatenotification apps enabled
  3. Add a non-admin group to the "Notify members of the following groups about available updates:"
  4. Run cron.php
  5. As non-admin hover the text of the notification, and try to follow the link :/

@nickvergessen nickvergessen added this to the Nextcloud 12.0 milestone Dec 19, 2016
@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer and @LukasReschke to be potential reviewers.

@ChristophWurst
Copy link
Member

conflicting

@nickvergessen
Copy link
Member Author

Replaced by #2982

@nickvergessen nickvergessen deleted the no-clickable-link-for-non-admins branch January 10, 2017 13:16
@AveryPalmer AveryPalmer mentioned this pull request Jun 12, 2023
Open
@CxsLucyfer CxsLucyfer mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: activity and notification feature: install and update
Projects
None yet
Milestone
Nextcloud 12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @mention-bot @ChristophWurst