-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly cleanup entries of WebAuthn on user deletion #27532
Merged
MorrisJobke
merged 1 commit into
master
from
fix/noid/properly-cleanup-webauthn-user-deletion
Jun 18, 2021
Merged
Properly cleanup entries of WebAuthn on user deletion #27532
MorrisJobke
merged 1 commit into
master
from
fix/noid/properly-cleanup-webauthn-user-deletion
Jun 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested review from
PVince81,
LukasReschke,
ChristophWurst and
blizzz
June 16, 2021 15:05
LukasReschke
approved these changes
Jun 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
/backport to stable21 |
/backport to stable20 |
/backport to stable19 |
ChristophWurst
approved these changes
Jun 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful
Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Jun 18, 2021
MorrisJobke
force-pushed
the
fix/noid/properly-cleanup-webauthn-user-deletion
branch
from
June 18, 2021 07:42
c07d414
to
dbed0ce
Compare
Code style fixed ✅ |
This was referenced Jun 18, 2021
Manual backport at #27596 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add listener on user deletion to clean up the webauthn table.