-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make Provisioning API aware of multiple mails #27474
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
force-pushed
the
feat/26866/prov-api
branch
2 times, most recently
from
June 11, 2021 14:14
e3eaac3
to
84d1cd2
Compare
Pytal
reviewed
Jun 11, 2021
blizzz
force-pushed
the
feat/26866/prov-api
branch
2 times, most recently
from
June 14, 2021 11:05
3f5a7b0
to
3637af2
Compare
This comment has been minimized.
This comment has been minimized.
blizzz
force-pushed
the
feat/26866/prov-api
branch
from
June 14, 2021 17:06
085fd99
to
784b61e
Compare
blizzz
force-pushed
the
feat/26866/prov-api
branch
from
June 17, 2021 00:05
5a6216b
to
9a320f1
Compare
Pytal
reviewed
Jun 21, 2021
blizzz
force-pushed
the
feat/26866/prov-api
branch
2 times, most recently
from
June 22, 2021 16:23
fb905d4
to
ee5b4ac
Compare
Pytal
reviewed
Jun 22, 2021
blizzz
force-pushed
the
feat/26866/prov-api
branch
3 times, most recently
from
June 25, 2021 19:40
e33d30a
to
3561025
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
blizzz
force-pushed
the
feat/26866/prov-api
branch
from
June 29, 2021 11:46
bd9dafe
to
38a2a6b
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
- format as stored previously in oc_accounts table is kept Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
- fixes wrong veriable usage also Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
feat/26866/prov-api
branch
from
June 29, 2021 22:50
ff99a05
to
19d014f
Compare
blizzz
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Jun 29, 2021
blizzz
force-pushed
the
feat/26866/prov-api
branch
from
June 29, 2021 23:03
19d014f
to
ad0a11b
Compare
Signed-off-by: Arthur Schiwon <[email protected]>
Pytal
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🎉🎉
skjnldsv
approved these changes
Jun 30, 2021
/backport to stable22 |
nickvergessen
requested changes
Jun 30, 2021
blizzz
added
the
pending documentation
This pull request needs an associated documentation update
label
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
enhancement
pending documentation
This pull request needs an associated documentation update
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the provisioning API as following
getUser
endpoint:
ocs/v2.php/cloud/users/2d42e983-a7a8-40b1-8e4a-b8afeb5244240b
Original response
New, with no additional mail set
New, with one or more additional mail set
getEditableFields(ForUser)
endpoint:
ocs/v2.php/cloud/user/fields/e8a7e882-5c5e-4f61-b6bb-bc5fd9b3cb4b
one entry added unconditionally
editUser
endpoint:
ocs/v2.php/cloud/users/2d42e983-a7a8-40b1-8e4a-b8afeb5244240b
method:
PUT
To add an additional email, just use 'additional_mail' as key.
Deleting and setting scope is not possible with this endpoint as we need the value as reference.
editUserMultiValue
endpoint:
ocs/v2.php/cloud/users/2d42e983-a7a8-40b1-8e4a-b8afeb5244240b/{collectionName}
method:
PUT
key
parameter and leave the value empty. Future properties may implement renaming by usingkey
as old value andvalue
as new value.Scope
suffix to the collectionName.key
is the mail address,value
the scope value.contributes to #26866