-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable20] avoid fread on directories and unencrypted files #27407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
danxuliu,
icewind1991,
jknockaert,
juliusknorr,
kesselb,
rullzer,
schiessle and
vitormattos
June 6, 2021 18:02
CI is unhappy |
/rebase |
Reworking the logic in order to first check the filecache and only then reading the fileheader. This in order to solve #21578.
Signed-off-by: Jasper Knockaert [email protected]
nextcloud-command
force-pushed
the
backport/24966/stable20
branch
from
September 3, 2021 13:42
82cd9ed
to
8466c53
Compare
MichaIng
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
2. developing
Work in progress
labels
Sep 3, 2021
All fine now, only DCO is unhappy. |
MichaIng
approved these changes
Sep 3, 2021
blizzz
approved these changes
Sep 23, 2021
Let's assume them being signed-off in master is sufficient |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #24966