Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable20] Make user:report command scale #27319

Merged
merged 1 commit into from
Jun 1, 2021
Merged

[stable20] Make user:report command scale #27319

merged 1 commit into from
Jun 1, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #27099

@nickvergessen @backportbot
Make user:report command scale
e7adbbf 
Signed-off-by: Joas Schilling <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 20.0.11 milestone Jun 1, 2021
@nickvergessen
Copy link
Member

Test seems unrelated

@skjnldsv skjnldsv merged commit 8246290 into stable20 Jun 1, 2021
@skjnldsv skjnldsv deleted the backport/27099/stable20 branch June 1, 2021 12:10
@skjnldsv skjnldsv added the 4. to release Ready to be released and/or waiting for tests to finish label Jun 1, 2021
@MorrisJobke
Copy link
Member 

 /home/runner/work/server/server/lib/private/Avatar/Avatar.php:145:13:error - InvalidNullableReturnType: The declared return type 'bool|string' for OC\Avatar\Avatar::generateAvatarFromSvg is not nullable, but 'false|null|string' contains null
/home/runner/work/server/server/lib/private/Avatar/Avatar.php:159:25:error - ImplicitToStringCast: Argument 1 of OC_Image::loadFromData expects string, Imagick provided with a __toString method
/home/runner/work/server/server/lib/private/Avatar/Avatar.php:160:11:error - NullableReturnStatement: The declared return type 'bool|string' for OC\Avatar\Avatar::generateAvatarFromSvg is not nullable, but the function returns 'null|string'

Those are new psalm failures starting with this PR (but there weren't many merged before this - so it is most likely some external change)

@nickvergessen
Copy link
Member

Not sure how this could be related.

@blizzz blizzz mentioned this pull request Jun 23, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: users and groups
Projects
None yet
Milestone
Nextcloud 20.0.11
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @MorrisJobke @skjnldsv