new ftp backend #27194
Merged
new ftp backend #27194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
new-ftp
branch
12 times, most recently
from
9389433
to
a3f893e
Compare
icewind1991
added
3. to review
Signed-off-by: Robin Appelman <[email protected]>
this uses the raw `ftp_` functions instead of the stream wrapper Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
skjnldsv
reviewed
Oct 7, 2021
skjnldsv
reviewed
Oct 7, 2021
Signed-off-by: Robin Appelman <[email protected]>
PVince81
approved these changes
Oct 7, 2021
Signed-off-by: Robin Appelman <[email protected]>
skjnldsv
approved these changes
Oct 8, 2021
Merged
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New FTP storage backend that instead of using php's ftp streamwrapper directly uses the
ftp_methods.This removes some of the restrictions of the php stream wrapper (most notably being the inability to work with anything with a
#in the filename) and gives more flexibility for working around some incompatibilities between server implementations.Additionally this adds a new testing setup to test the ftp implementation against various ftp servers to ensure that all the various implementation differences are accounted for. The tests are setup to run only when
files_externalis touched to prevent wasting github's cpu cycles.