Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not use private AccountManager in UsersController #27035

Merged
merged 1 commit into from
May 25, 2021
Merged

do not use private AccountManager in UsersController #27035

merged 1 commit into from
May 25, 2021

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented May 19, 2021

  • extends IAccountProperty for verificationData getters and setters
  • implementation thereof ^
  • and of course adaption of UsersController

contributes to #26866

@blizzz blizzz added this to the Nextcloud 22 milestone May 19, 2021
@MorrisJobke MorrisJobke mentioned this pull request May 20, 2021
Merged
@blizzz blizzz force-pushed the techdebt/26866/userscontroller-accountmanager-api branch 3 times, most recently from fd45828 to dd1f793 Compare May 21, 2021 12:24
@blizzz blizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 21, 2021
@blizzz blizzz force-pushed the techdebt/26866/userscontroller-accountmanager-api branch from dd1f793 to f3989b8 Compare May 21, 2021 17:19
nickvergessen
nickvergessen approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PVince81
PVince81 approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks fine

please consider my minor comment about in_array

apps/settings/lib/Controller/UsersController.php Outdated Show resolved Hide resolved
@blizzz blizzz force-pushed the techdebt/26866/userscontroller-accountmanager-api branch from f3989b8 to 847ed37 Compare May 25, 2021 12:35
@blizzz
do not use private AccountManager in UsersController
847ed37 
- extends IAccountProperty for verificationData getters and setters
- implementation thereof ^
- and of course adaption of UsersController

Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 25, 2021
@blizzz blizzz merged commit 1b47886 into master May 25, 2021
@blizzz blizzz deleted the techdebt/26866/userscontroller-accountmanager-api branch May 25, 2021 19:22
@MorrisJobke MorrisJobke mentioned this pull request May 26, 2021
Merged
98 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@PVince81 PVince81 PVince81 approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement technical debt
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
4 participants
@blizzz @nickvergessen @PVince81 @juliusknorr