explicitly close source stream on object store upload even if count… #26832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rapper isn't needed Signed-off-by: Robin Appelman <[email protected]>
Merged
kesselb
approved these changes
May 21, 2021
juliusknorr
approved these changes
May 21, 2021
|
/backport to stable21 |
|
/backport to stable20 |
|
The backport to stable20 failed. Please do this backport manually. |
|
The backport to stable21 failed. Please do this backport manually. |
This change is also relevant for the opposite case. If the stream is not closed explicitly a callback for stream_close might be executed too late. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrapper isn't needed
This might solve some issues around gc getting triggered before stream_close callbacks