-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proper message to created share not found #26688
Conversation
/backport to stable21 |
/backport to stable20 |
/backport to stable19 |
b7bdbbf
to
3612a10
Compare
@@ -223,7 +223,7 @@ public function create(\OCP\Share\IShare $share) { | |||
$cursor->closeCursor(); | |||
|
|||
if ($data === false) { | |||
throw new ShareNotFound(); | |||
throw new ShareNotFound('Newly created share could not be found'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this returned to the end user? Or is this just for the logs? I'm asking because of the potential need to translate this.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah no, this is actually read for the end user too.
But this is technical, if we reach this error the admin must know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmmmh ... but even then it should either be "there was an error - reach out to the admin" or a localized error message if the user can do something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But yeah - it was untranslated before. So I will not block this because of the refined message. But we should look into this, because it is a HintException which will show the hint to the end user and print the message to the logs. (if no hint provided it uses the message)
So maybe we could add a generic and translated "Something broke" as hint and give this detailed message as internal message.
See #26716 |
/rebase |
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
3612a10
to
e3fa686
Compare
/backport to stable22 |
Otherwise the extend of the GenericShareException replace with a completely unrelated and cryptic message
server/lib/public/Share/Exceptions/GenericShareException.php
Lines 35 to 47 in 45a4740