cleaning useless call to circleDetails() #26522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxence Lange <[email protected]>
ArtificialOwl
requested review from
ChristophWurst,
skjnldsv and
rullzer
and removed request for
ChristophWurst and
skjnldsv
skjnldsv
approved these changes
Apr 13, 2021
rullzer
approved these changes
Apr 13, 2021
Merged
|
Seems to be the same as in #26890 ... Psalm is unhappy, because it seems to infer some types from this code that otherwise cause trouble later on. 🤔 |
|
ping @daita |
skjnldsv
added
2. developing
|
yup, pretty similar to #26890, can be closed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can start cleaning this code.
The call to circleDetails is useless as the check on memberships is done in the ShareProvider from the Circles App on new/edit share