Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gracefully handle deleteFromSelf when share is already gone #26372

Merged
merged 1 commit into from
Mar 30, 2021
Merged

gracefully handle deleteFromSelf when share is already gone #26372

merged 1 commit into from
Mar 30, 2021

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Mar 30, 2021

  • handling race conditions

@blizzz
gracefully handle deleteFromSelf when share is already gone
be3ae9a 
- handling race conditions

Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz blizzz added this to the Nextcloud 22 milestone Mar 30, 2021
rullzer
rullzer approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane

@rullzer rullzer merged commit 06ae9c3 into master Mar 30, 2021
@rullzer rullzer deleted the fix/noid/calm-down-recipient-not-in-grp branch March 30, 2021 18:52
@blizzz
Copy link
Member Author

blizzz commented Mar 30, 2021

/backport to stable21

@blizzz
Copy link
Member Author

blizzz commented Mar 30, 2021

/backport to stable20

@blizzz
Copy link
Member Author

blizzz commented Mar 30, 2021

/backport to stable19

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 30, 2021
Merged
This was referenced Mar 30, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer rullzer approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@kesselb kesselb Awaiting requested review from kesselb

@Mikescops Mikescops Awaiting requested review from Mikescops

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: sharing
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
3 participants
@blizzz @rullzer @skjnldsv