Catch invalid cache source storage path #26270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
added
bug
3. to review
skjnldsv
requested review from
rullzer,
nickvergessen,
MorrisJobke,
icewind1991 and
blizzz
|
/backport to stable21 |
|
/backport to stable20 |
|
/backport to stable19 |
|
😭 |
|
Shouldn't psalm catch this? |
MorrisJobke
approved these changes
Mar 24, 2021
blizzz
approved these changes
Mar 24, 2021
This was referenced Mar 24, 2021
joshtrichards
added a commit
to joshtrichards/nc-server
that referenced
this pull request
Aug 3, 2023
OC\Files\Cache\Cache::get can return string|false|null, not just string|false. - nextcloud#26270 added handling of false, but null is needed too. - Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason Related: nextcloud#19009 Signed-off-by: Josh Richards <[email protected]>
5 tasks
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Aug 5, 2023
OC\Files\Cache\Cache::get can return string|false|null, not just string|false. - #26270 added handling of false, but null is needed too. - Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason Related: #19009 Signed-off-by: Josh Richards <[email protected]>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Aug 5, 2023
OC\Files\Cache\Cache::get can return string|false|null, not just string|false. - #26270 added handling of false, but null is needed too. - Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason Related: #19009 Signed-off-by: Josh Richards <[email protected]>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Aug 6, 2023
OC\Files\Cache\Cache::get can return string|false|null, not just string|false. - #26270 added handling of false, but null is needed too. - Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason Related: #19009 Signed-off-by: Josh Richards <[email protected]>
kesselb
pushed a commit
that referenced
this pull request
Dec 1, 2023
OC\Files\Cache\Cache::get can return string|false|null, not just string|false. - #26270 added handling of false, but null is needed too. - Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason Related: #19009 Signed-off-by: Josh Richards <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OC\Files\Cache\Cache::getcan also return false