adds ldap user:reset command #26076
Merged
adds ldap user:reset command #26076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
requested review from
rullzer,
ChristophWurst,
wiswedel,
juliusknorr and
skjnldsv
|
/backport to stable21 |
|
/backport to stable20 |
skjnldsv
reviewed
Mar 16, 2021
| IUserManager $userManager, | ||
| UserPluginManager $pluginManager | ||
| ) { | ||
| $this->dui = $dui; |
There was a problem hiding this comment.
skjnldsv
approved these changes
Mar 16, 2021
ChristophWurst
approved these changes
Mar 17, 2021
- allows to delete data of existing LDAP users, which otherwise is safe guarded - ensures that the user is not being deleted on LDAP through a plugin Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
enh/noid/ldap-occ-user-reset
branch
from
674e262
to
1b0355f
Compare
blizzz
added
4. to release
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns the double-step of flagging a user as deleted and running the user:delete routine into a single step with another safety check and without possible cache race conditions.