-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix user list infinite loading state in user settings #25879
Conversation
master is 22. Backport once merge if needed. |
Any update here? |
This comment has been minimized.
This comment has been minimized.
5a6f497
to
71b4db1
Compare
/compile amend / |
71b4db1
to
2c23829
Compare
2c23829
to
14f2863
Compare
865a626
to
52be852
Compare
I don't know why |
52be852
to
517e399
Compare
/rebase |
/compile amend / |
517e399
to
f56553f
Compare
/rebase |
@eneiluj please rebase |
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
f56553f
to
073a673
Compare
@szaimen done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
/backport to stable22 |
/backport to stable21 |
/backport to stable20 |
The backport to stable22 failed. Please do this backport manually. |
The backport to stable20 failed. Please do this backport manually. |
The backport to stable21 failed. Please do this backport manually. |
/backport to stable22 |
The backport to stable22 failed. Please do this backport manually. |
I don't know why but this bug does not affect stable20 although the implementation is the same. Anyway, no need to backport to stable20 😁. |
Thanks for the backports! :) |
Fix #25133
This is the same as #25195 but rebased on master with resolved conflicts.
"No users in here" message is shown when there actually are displayed users.
This is because
$state.loaded()
is not called when the retrieved user list length is less than the 25 limit. It has to be called at least once otherwise vue-infinite-loading shows theno-results
slot.$state.loaded()
is now called if we actually fetch users.There is still one problem with this approach:
If we receive users but the displayed filtered list is empty, the
no-results
slot will not be displayed because we called$state.loaded()
.We could face this problem with the "Disabled" filter but thankfully the related navigation item does not appear when there is no disabled user.
But it might appear in the future with a new filter that can be applied while it leads to an empty displayed user list.