Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear multiselect after selection in share panel #25805

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Clear multiselect after selection in share panel #25805

merged 1 commit into from
Mar 3, 2021

Conversation

PVince81
Copy link
Member

@skjnldsv not sure why this was disabled in the first place ? Are there use cases where we want to keep the input contents after clicking ?

Fixes #23468

@PVince81 PVince81 added this to the Nextcloud 22 milestone Feb 26, 2021
@PVince81 PVince81 self-assigned this Feb 26, 2021
@PVince81 PVince81 mentioned this pull request Feb 26, 2021
Closed
@skjnldsv
Copy link
Member

skjnldsv commented Mar 2, 2021 •
edited
Loading

Are there use cases where we want to keep the input contents after clicking ?

Yeah, iirc that was a request we had a long time ago, so you could easily batch-add similar searches. Like search for a mail domain @nextcloud.com and add multiple results without typing every time

EDIT: but can't find original PR. Maybe I'm wrong. Ping @jancborchardt, please decide :)

@jancborchardt
Copy link
Member

Good question – @skjnldsv I also don’t remember a specific request like this.

I’d say @PVince81’s change is good. Also e.g. in the case of emails, people probably copy-paste rather than typing. 👍

skjnldsv
skjnldsv approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go then! :)

marcoambrosini
marcoambrosini approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@rullzer rullzer force-pushed the bugfix/23468/clear-share-after-select branch from 46e9615 to c541094 Compare March 3, 2021 10:37
@PVince81
Copy link
Member Author

PVince81 commented Mar 3, 2021

/backport to stable21

@PVince81
Copy link
Member Author

PVince81 commented Mar 3, 2021

/backport to stable20

@juliusknorr juliusknorr merged commit 895e6a5 into master Mar 3, 2021
@juliusknorr juliusknorr deleted the bugfix/23468/clear-share-after-select branch March 3, 2021 16:25
This was referenced Mar 3, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@PVince81 PVince81

Labels
3. to review Waiting for reviews bug regression
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.

Share field not cleared/reset after adding recipient
5 participants
@PVince81 @skjnldsv @jancborchardt @juliusknorr @marcoambrosini