Add button color variables

[marcoambrosini]

No description provided.

[rullzer]

So... what is the status here?

[marcoambrosini]

So... what is the status here?

Back on it these days :)

[artonge]

Is this to prevent the vue button from being styled from here ? Is this really necessary as it is probably scoped ?

[marcoambrosini]

The server style is not scoped and it targets everything unless we do this

[artonge]

Hmm, ok, I thought that vue components could be isolated from external CSS. Maybe I am wrong :)

[ChristophWurst]

@marcoambrosini please document this breaking change in #27846. Mail and likely other apps using nc/vue break because of this change if I understand this correctly. cc @GretaD

[raimund-schluessler]

Will this be backported?

[marcoambrosini]

/backport to stable22

[raimund-schluessler]

Can we backport it to stable21 and stable20 as well? Would help using the button component.

I will give backporting a try, let's see if it works.

[raimund-schluessler]

/backport to stable21

[raimund-schluessler]

/backport to stable20

[ChristophWurst]

Can we backport it to stable21 and stable20 as well? Would help using the button component.

I see where this is coming from but I'm really not sure if backporting is such a great idea. After all any apps installed in existing Nextcloud installations of v20, v21 and v22 will work or break depending on which patch version they are on.

I would rather make a the button a breaking change in nc/vue and a hard requirement on Nextcloud 23. Then we have som certainty that the app we ship also works in the intended way.

General rule: we don't backport features. Only fixes are backported.

[raimund-schluessler]

General rule: we don't backport features. Only fixes are backported.

In that case, e.g the Tasks app can only start using the Button component once v23 is the oldest supported server version (July 2022), since we aim at supporting all still supported server versions with the same release.