Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix admin password strengthify tooltip #25712

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Fix admin password strengthify tooltip #25712

merged 1 commit into from
Mar 1, 2021

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Feb 18, 2021

Fixes the admin password strengthify tooltip not being shown on the install page.

Unfortunately, the console is spammed with unavoidable deprecation warnings (ref #12980):
tooltip.js:36 Deprecated call $.tooltip('fixTitle') has been deprecated and should be removed

This has to be fixed in the upstream library at https://github.com/MorrisJobke/strengthify.

Before

tooltip-before

Console error:

jquery.strengthify.js:158 Uncaught TypeError: $wrapper.attr(...).tooltip is not a function
    at HTMLInputElement.drawStrengthify (jquery.strengthify.js:158)
    at HTMLInputElement.dispatch (jquery.js:5183)
    at HTMLInputElement.elemData.handle (jquery.js:4991)

After

tooltip-after

@st3iny st3iny added the 3. to review Waiting for reviews label Feb 18, 2021
@st3iny st3iny self-assigned this Feb 18, 2021
@st3iny st3iny force-pushed the fix/noid/admin-password-tooltip branch from 4e2107a to a785da3 Compare February 19, 2021 08:48
@st3iny
Copy link
Member Author

st3iny commented Feb 19, 2021

Rebased and fixed node build job

@st3iny st3iny force-pushed the fix/noid/admin-password-tooltip branch from a785da3 to 2771e44 Compare February 22, 2021 20:31
@st3iny st3iny requested a review from skjnldsv February 23, 2021 10:28
@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 24, 2021
@skjnldsv skjnldsv merged commit 92d6abf into master Mar 1, 2021
@skjnldsv skjnldsv deleted the fix/noid/admin-password-tooltip branch March 1, 2021 13:52
@st3iny
Copy link
Member Author

st3iny commented Mar 5, 2021

/backport to stable21

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 5, 2021
Merged
@st3iny
Copy link
Member Author

st3iny commented Mar 5, 2021

/backport to stable20

@st3iny
Copy link
Member Author

st3iny commented Mar 5, 2021

/backport to stable19

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 5, 2021
Merged
@backportbot-nextcloud
Copy link

The backport to stable19 failed. Please do this backport manually.

@st3iny st3iny mentioned this pull request Mar 5, 2021
Merged
@st3iny st3iny added this to the Nextcloud 22 milestone Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees

@st3iny st3iny

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: install and update
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
3 participants
@st3iny @juliusknorr @skjnldsv