Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable19] [CalDAV] Validate notified emails #25323

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jan 25, 2021

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #25310

@nickvergessen
Copy link
Member

@tcitworld the backport didn't work completly, can you check?

@nickvergessen nickvergessen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 26, 2021
Signed-off-by: Thomas Citharel <[email protected]>
@tcitworld tcitworld added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 26, 2021
@tcitworld
Copy link
Member

Should be fine now.

@faily-bot
Copy link

faily-bot bot commented Jan 26, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1694: failure

mariadb10.4-php7.3

Show full log
There was 1 error:

1) OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testCreate
OCP\Share\Exceptions\ShareNotFound: There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted.

/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:863
/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:242
/drone/src/apps/federatedfilesharing/tests/FederatedShareProviderTest.php:187

--

There were 3 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
Cannot stub or mock class or interface "OCA\Files_Sharing\Tests\External\IManager" which does not exist

@rullzer rullzer merged commit 0fe59bc into stable19 Jan 27, 2021
@rullzer rullzer deleted the backport/25310/stable19 branch January 27, 2021 13:49
@rullzer rullzer mentioned this pull request Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants