Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix apppassword dropdown issues #2532

Merged
merged 3 commits into from
Dec 6, 2016
Merged

Fix apppassword dropdown issues #2532

merged 3 commits into from
Dec 6, 2016

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Dec 6, 2016
@icewind1991 icewind1991 added this to the Nextcloud 11.0 milestone Dec 6, 2016
@mention-bot
Copy link

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @ChristophWurst and @MorrisJobke to be potential reviewers.

@MorrisJobke
Copy link
Member

MorrisJobke commented Dec 6, 2016 •
edited by icewind1991
Loading

Tested and works 👍

Either something for this PR or another one (because also broken on master):

  • clicking somewhere outside of the menu or the 3 dots again should also close the current menu

@icewind1991
Copy link
Member Author

clicking somewhere outside of the menu or the 3 dots again should also close the current menu

Done

@MorrisJobke
Copy link
Member

Tested in Firefox, Chrome, Safari, Edge and IE11 and it works 👍

@MorrisJobke
Copy link
Member

@nickvergessen @skjnldsv @rullzer @nextcloud/designers Mind to review this one?

@skjnldsv
Copy link
Member

skjnldsv commented Dec 6, 2016

👍 Perfect!

Just a small question, shouldn't we always display the three dots? Because on mobile the user won't know there is an option! 😕

@MorrisJobke
Copy link
Member

Just a small question, shouldn't we always display the three dots? Because on mobile the user won't know there is an option! 😕

Makes sense

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 6, 2016
@schiessle schiessle merged commit 0b0f273 into master Dec 6, 2016
@schiessle schiessle deleted the token-dropdown branch December 6, 2016 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@icewind1991 @mention-bot @MorrisJobke @skjnldsv @schiessle