-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add activity for display name change #25148
Conversation
9dfd938
to
20499c1
Compare
let me see what happens when the name changed on LDAP and got synced down |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
20499c1
to
d01d2c1
Compare
Works now, when it is updated by the system (occ or background job for instance) it is fine. There is another edge case: This was during normal operation of that user and due to cold cache. This can happen when the user is included in a search operation by someone else, then it was xyz who changed the displayname. But then the better change would be to not update the displayname on action, but leave it to the background job as well. Let me take care of that. Users that are being soaked in for the first time do not see the activity. This is better not a race condition :D Apart of that I expect the ajax-type job does not run with context of the logged in user. |
So we are good to go? |
It has false claims for LDAP users (stuff like "Your displayname was updated by AnotherUser" if the other user searched for something and your entry was updated by the system). I don't like this that much. Also back porting then the big change by @blizzz that changes the fetching of LDAP data is also something I don't fully like. :( Let's keep this a bit longer here. Maybe @blizzz has an idea how to nicely work around this situation. |
Moved. We can still backport from 22 if the changes are small. |
and am afraid once more to 23. still work to be done. and conflicts to resolve. |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Morris Jobke <[email protected]>
d01d2c1
to
6a99f21
Compare
Test are green. @blizzz wanna do something on top of that? |
Tricky to solve and most likely needs a more advanced way of doing it. Therefore I will close this one here. Feel free to take parts of this into a new PR. |
Looks then like this: